Skip to content

Mention colorbar.minorticks_on/off in references #12130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2018
Merged

Mention colorbar.minorticks_on/off in references #12130

merged 1 commit into from
Sep 15, 2018

Conversation

pharshalp
Copy link
Contributor

@pharshalp pharshalp commented Sep 15, 2018 •
edited
Loading

PR Summary

I forgot to mention the newly introduced (#11584) colorbar.minorticks_on/off method in the references for the example.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@pharshalp pharshalp mentioned this pull request Sep 15, 2018
Merged
2 tasks
@tacaswell tacaswell added this to the v3.0 milestone Sep 15, 2018
@tacaswell
Copy link
Member

Thanks for the diligence in documentation, however the referneces do not seem to be quite right

Warning, treated as error:
/home/circleci/project/examples/color/colorbar_basics.py failed to execute correctly: Traceback (most recent call last):
  File "/home/circleci/project/examples/color/colorbar_basics.py", line 62, in <module>
    matplotlib.pyplot.colorbar.minorticks_on
AttributeError: 'function' object has no attribute 'minorticks_on'

@pharshalp
Mention colorbar.minorticks_on/off in references
3f8dd62 
Fixed incorrect reference to colorbar.minorticks_on/off
@pharshalp
Copy link
Contributor Author

pharshalp commented Sep 15, 2018 •
edited
Loading

Thanks for the diligence in documentation, however the referneces do not seem to be quite right

Warning, treated as error:
/home/circleci/project/examples/color/colorbar_basics.py failed to execute correctly: Traceback (most recent call last):
  File "/home/circleci/project/examples/color/colorbar_basics.py", line 62, in <module>
    matplotlib.pyplot.colorbar.minorticks_on
AttributeError: 'function' object has no attribute 'minorticks_on'

@tacaswell thanks. (squashed and) pushed a fix.
Update: looks like it passes all the checks.

@tacaswell tacaswell merged commit 68314b0 into matplotlib:master Sep 15, 2018
@tacaswell
Copy link
Member

Thanks @pharshalp !

@pharshalp pharshalp deleted the fix_example_colorbar_basics branch September 15, 2018 22:32
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 15, 2018
@tacaswell
Backport PR matplotlib#12130: Mention colorbar.minorticks_on/off in r…
1c56f2b 
…eferences
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 15, 2018
Merged
tacaswell added a commit that referenced this pull request Sep 15, 2018
@tacaswell
Merge pull request #12132 from meeseeksmachine/auto-backport-of-pr-12…
a9402c0 
…130-on-v3.0.x

Backport PR #12130 on branch v3.0.x (Mention colorbar.minorticks_on/off in references)
@pharshalp pharshalp restored the fix_example_colorbar_basics branch September 16, 2018 03:16
@pharshalp pharshalp deleted the fix_example_colorbar_basics branch September 16, 2018 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pharshalp @tacaswell