Skip to content

BLD: pragmatic fix for building basic_unit example on py37 #12148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

tacaswell
Copy link
Member

This restores the formerly implicit 'cwd' in the path.

closes #11838

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

This restores the formerly implicit 'cwd' in the path.

closes matplotlib#11838
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@jklymak jklymak added this to the v3.0.x milestone Sep 18, 2018
@jklymak jklymak merged commit 1232fdf into matplotlib:master Sep 18, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 18, 2018
dstansby added a commit that referenced this pull request Sep 18, 2018
…148-on-v3.0.x

Backport PR #12148 on branch v3.0.x (BLD: pragmatic fix for building basic_unit example on py37)
@tacaswell tacaswell deleted the doc_build_on_py37 branch September 18, 2018 17:34
@tacaswell tacaswell modified the milestones: v3.0.x, v3.0.0-doc Sep 18, 2018
tacaswell pushed a commit that referenced this pull request Sep 19, 2018
BLD: pragmatic fix for building basic_unit example on py37
@tacaswell
Copy link
Member Author

Mantually backported to v3.0.0-doc as 9a318f0

@tacaswell tacaswell modified the milestones: v3.0.0-doc, v2.2.4 Feb 12, 2019
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Feb 12, 2019
BLD: pragmatic fix for building basic_unit example on py37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs do not build on py3.7 due to small change in python handling of -m
3 participants