Skip to content

Deprecate considering *args, **kwargs in Timer.remove_callback. #12170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2019
Merged

Deprecate considering *args, **kwargs in Timer.remove_callback. #12170

merged 1 commit into from
Mar 18, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 19, 2018

PR Summary

See #12035.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Sep 19, 2018
timhoffm
timhoffm approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. However I would like @tacaswell to approve and merge the API change.

@tacaswell tacaswell merged commit 71338e3 into matplotlib:master Mar 18, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 18, 2019
@tacaswell
Backport PR matplotlib#12170: Deprecate considering *args, **kwargs i…
ea90e38 
…n Timer.remove_callback.
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 18, 2019
Merged
@anntzer anntzer deleted the Timer.remove_callback branch March 18, 2019 19:04
jklymak added a commit that referenced this pull request Mar 18, 2019
@jklymak
Merge pull request #13703 from meeseeksmachine/auto-backport-of-pr-12…
7e7fe36 
…170-on-v3.1.x

Backport PR #12170 on branch v3.1.x (Deprecate considering *args, **kwargs in Timer.remove_callback.)
@ksunden ksunden mentioned this pull request May 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @timhoffm @tacaswell