FIX: don't check for interactive framework if none required #12207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine, though I have no idea whether that helps with the issue or not. |
tacaswell
approved these changes
Sep 22, 2018
|
It stops instantiating macOSx framework if no framework is required. |
QuLogic
approved these changes
Sep 23, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 23, 2018
…ork if none required
dstansby
added a commit
that referenced
this pull request
Sep 23, 2018
…207-on-v3.0.x Backport PR #12207 on branch v3.0.x (FIX: dont' check for interactive framework if none required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #12188
Don't check the interactive framework if none is required...
Still tries the framework if a GUI is required, so pythons that pop up a GUI when the framework is started (i.e. OSX Framework builds) will pop up a gui when pyplot is imported.
PR Checklist