Merge OSXInstalledFonts into findSystemFonts. #12219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't much of a point of reproducing the logic of findSystemFonts into OSXInstalledFonts just with a different list of directories.
timhoffm
approved these changes
Sep 22, 2018
QuLogic
reviewed
Sep 23, 2018
| if sys.platform == 'darwin': | ||
| fontfiles.update(OSXInstalledFonts(fontext=fontext)) | ||
| fontpaths = [*X11FontDirectories, *OSXFontDirectories] |
There was a problem hiding this comment.
The new list expansions are nice, but this is just fontpaths += OSXFontDirectories, no?
There was a problem hiding this comment.
I don't want to overwrite the global X11FontsDirectories in place... (I guess I could do a copy above instead if you prefer.)
jklymak
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't much of a point of reproducing the logic of findSystemFonts
into OSXInstalledFonts just with a different list of directories.
Noticed while thinking about #12173 (comment).
PR Summary
PR Checklist