-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Remove extraneous if 1 statements in demo_axisline_style.py #12222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
removed the confusing if 1: as propsed in #12191
I am yet to change the other one, will add that commit here too! |
Took liberty of making a more descriptive title. ... |
updated with changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Apart from the minor style issue, this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's see if CI agrees.
@QuLogic Did you mean something like this? |
Yes, that is fine. You have some flake8 errors though:
|
@meeseeksdev backport to v3.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Meh, I don't see the need. |
removed the confusing if 1: as propsed in #12191
PR Summary
PR Checklist