Skip to content

Merge barchart examples. #12244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 24, 2018

lines_bars_and_markers/barchart and the first half of
statistics/barchart_demo are basically the same examples with some
additional labeling on the former. Move the additional features of the
former to the latter.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

lines_bars_and_markers/barchart and the first half of
statistics/barchart_demo are basically the same examples with some
additional labeling on the former.  Move the additional features of the
former to the latter.
@anntzer anntzer force-pushed the merge-barchart-examples branch from b3bdc08 to 5608ac3 Compare September 24, 2018 09:56
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. https://circleci.com/gh/anntzer/matplotlib/4269/artifacts/0//home/circleci/project/doc/build/html/index.html

What is the policy abotu removing examples? Do we just let them go away or do we redirect them somewhere? If someone linked the canonical barchart.html would they get 404 on the new version of the docs?

@anntzer
Copy link
Contributor Author

anntzer commented Oct 2, 2018

There's no redirection right now. I think we should redirect matplotlib.org/gallery/... to matplotlib.org/$version/gallery/... (which is what cpython does) so that people don't bookmark links that will be broken in the future, but that's a wholly separate issue...

@jklymak jklymak merged commit e4608c1 into matplotlib:master Oct 2, 2018
@anntzer anntzer deleted the merge-barchart-examples branch October 2, 2018 19:58
@QuLogic QuLogic added this to the v3.1.0 milestone Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants