Skip to content

[DO NO MERGE] Remove deprecated OSX checks #12252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DO NO MERGE] Remove deprecated OSX checks #12252

wants to merge 1 commit into from

Conversation

dstansby
Copy link
Member

(at least locally) this fixes #12188 . All I have done is get rid of two deprecated functions, GetCurrentProcess, and SetFrontProcess. This seems to stop the bouncing. I guess that these need to be replaced with their modern alternatives, but I can't work out what they should be...

@dstansby
Copy link
Member Author

Okay, so it turns out that this doesn't error properly on non-framework versions of python, so it looks like the check relies on trying to spawn a process using GetCurrentProcess and SetFrontProcess.

@tacaswell tacaswell added this to the v3.0.x milestone Sep 24, 2018
@dstansby dstansby changed the title Remove deprecated OSX checks [DO NO MERGE] Remove deprecated OSX checks Sep 24, 2018
@QuLogic QuLogic modified the milestones: v3.0.x, unassigned Sep 24, 2018
@dstansby
Copy link
Member Author

dstansby commented Oct 4, 2018

For anyone following, it looks like we need to replace the lines I deleted with something from https://developer.apple.com/documentation/appkit/nsrunningapplication

@tacaswell tacaswell modified the milestones: unassigned, v3.1, v3.0.x Oct 4, 2018
@tacaswell
Copy link
Member

I assume there is some way to pick the code path based on the version of osx?

@dstansby
Copy link
Member Author

dstansby commented Oct 4, 2018

Yes, there's some version checks at the top of the file that I think would work.

@dstansby
Copy link
Member Author

dstansby commented Oct 4, 2018

Do we have a lowest-supported-version of OSX?

@jklymak
Copy link
Member

jklymak commented Oct 4, 2018

@dstansby: In #11850 I think we decided that we can't get rid of those deprecated functions. Sorry I should have kept better notes...

@tacaswell
Copy link
Member

We should be pretty not-aggressive about a minimum osx version. If you can get python 3.5 to run on it we should support it.

@dstansby dstansby mentioned this pull request Oct 19, 2018
Closed
@jklymak
Copy link
Member

jklymak commented Oct 25, 2018

Closing in lieu of #12603 which now goes back to using the more modern checks...

@jklymak jklymak closed this Oct 25, 2018
@QuLogic QuLogic modified the milestones: v3.0.1, unassigned Oct 25, 2018
@dstansby dstansby deleted the osx-bouncing-icon branch October 25, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI: MacOSX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

matplotlib 3 pyplot on MacOS bounces rocket icon in dock
4 participants
@dstansby @tacaswell @jklymak @QuLogic