Skip to content

Fix docs : change from issue #12191, remove "if 1:" blocks in examples #12260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 27, 2018
Merged

Fix docs : change from issue #12191, remove "if 1:" blocks in examples #12260

merged 23 commits into from
Sep 27, 2018

Conversation

abhinuvpitale
Copy link
Contributor

@abhinuvpitale abhinuvpitale commented Sep 25, 2018 •
edited
Loading

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@abhinuvpitale
Copy link
Contributor Author

@QuLogic updated and sent a PR here

@abhinuvpitale
Copy link
Contributor Author

@QuLogic updated and complete

@eric-wieser
Copy link
Contributor

cross-ref for clicking: #12191

QuLogic
QuLogic reviewed Sep 26, 2018
View reviewed changes
examples/misc/patheffect_demo.py Outdated
@@ -8,7 +8,7 @@
import matplotlib.patheffects as PathEffects
import numpy as np

if 1:
if __name__ == "__main__":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need for this if; there's nothing in the example without this code.

examples/text_labels_and_annotations/demo_annotation_box.py Outdated
@@ -13,7 +13,7 @@
from matplotlib.cbook import get_sample_data


if 1:
if __name__ == "__main__":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@QuLogic QuLogic merged commit 5cbc072 into matplotlib:master Sep 27, 2018
@QuLogic QuLogic added this to the v3.1 milestone Sep 27, 2018
@QuLogic QuLogic mentioned this pull request Sep 27, 2018
Closed
@abhinuvpitale abhinuvpitale deleted the fix-docs-12191 branch September 29, 2018 06:00
@jklymak jklymak mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@abhinuvpitale @eric-wieser @QuLogic @timhoffm @dstansby