FIX: Don't apply tight_layout if axes collapse #12285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you document that as an API change? Put it directly in |
|
|
timhoffm
reviewed
Oct 3, 2018
|
@timhoffm - is the new commit what you were after? Thanks! |
timhoffm
approved these changes
Oct 14, 2018
|
Flake8 says
|
|
Thanks! Evil trailing space eradicated.... |
a250c85 to
a58ce76
Compare
|
Thanks @jklymak ! Your work to make sure the tight/constrained layout works well is greatly appreciated! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 25, 2018
tacaswell
pushed a commit
that referenced
this pull request
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Partially addresses #12256
If tight_layout is called and there is an annotation or legend that is outside the axes, it can sometimes happen that the axes completely collapses. There is currently a warning, but this PR also doesn't apply tight_layout if that happens, under the assumption its better to draw something rather than draw something that is completely broken.
Note however, it is still possible for the axes to get quite small.
The origin of these issues is that
axes.get_tightbboxnow includes all artists when computing the bounding box, whereas before 3.0 it only included the axes elements themselves, and none of the artists. Now artists can be excluded by explictly settinga.set_inlayout(False).NOTE: this is an API change in that
tight_layout.auto_adjust_subplotparsnow can return None if no good subplotpars were computed.PR Checklist