Skip to content

Enable dynamic updating for the OS X backend #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2012

Conversation

dmcdougall
Copy link
Member

Before, on panning the figure in the OS X backend, the figure didn't update. This change updates the figure on a pan event.

@mdboom
Copy link
Member

mdboom commented Sep 11, 2012

This seems like a very useful and non-controversial fix -- and given that 1.2.0rc1 didn't get out yesterday, maybe it should go in? @efiring, @pelson, and other mac users -- do you agree? Any downside to this?

@efiring
Copy link
Member

efiring commented Sep 11, 2012

Fixing this will be great, and putting in the missing dynamic_update method makes sense. It looks like the simplest and safest way to fix a major shortcoming of the macosx backend.
Longer term, I note that dynamic_update is commented in the other backends (but not in backend_bases) as a "legacy method", however, and the only place it is used is in backend_bases drag_pan(). At some point, if not now, it presumably makes sense to replace it there with canvas.draw_idle, and consistently mark dynamic_update as deprecated. I haven't checked carefully, but I suspect it can be completely factored out into backend_bases.

@WeatherGod
Copy link
Member

I wonder if this would bring us a step closer to fixing issue #531? I have no pretense that it would be solved for v1.2.x, but I was just curious if this is a step in the right direction for it?

@efiring
Copy link
Member

efiring commented Sep 11, 2012

@WeatherGod, I don't think this is related to #531.

@efiring
Copy link
Member

efiring commented Sep 12, 2012

@mdboom, I think this should go in before rc2. It is a straightforward fix for a major shortcoming.

@mdboom
Copy link
Member

mdboom commented Sep 12, 2012

Merging into 1.2.x

mdboom added a commit that referenced this pull request Sep 12, 2012
Enable dynamic updating for the OS X backend
@mdboom mdboom merged commit 6b6e476 into matplotlib:master Sep 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants