Don't use stdlib private API in animation.py. #12368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37dcbe1 to
61a0e41
Compare
6 tasks
WeatherGod
requested changes
Oct 2, 2018
lib/matplotlib/animation.py
Outdated
| out = TextIOWrapper(BytesIO(out)).read() | ||
| err = TextIOWrapper(BytesIO(err)).read() | ||
| _log.debug("MovieWriter: stdout: %s", out) | ||
| _log.debug("MovieWriter: stderr: %s", err) |
There was a problem hiding this comment.
Can you put back the newlines? It helps when reading multi-line output.
There was a problem hiding this comment.
sure, this was just copied from the other block. fixed.
| return '', '' | ||
|
|
||
| self._proc = ProcessStandin() | ||
|
|
There was a problem hiding this comment.
Is removing this safe? self._run() is still called, I guess it is deferring to a baseclass implementation?
There was a problem hiding this comment.
The parent class (FileMovieWriter) invokes _run in finish:
def finish(self):
# Call run here now that all frame grabbing is done. All temp files
# are available to be assembled.
self._run()
MovieWriter.finish(self) # Will call clean-up
so if we override finish(), we don't call _run() at all.
(TBH I think the inheritance chain of methods could be refactored a bit but that's not the point of this PR.)
Also note that there is actually test coverage for this :)
The _std{out,err}_buff attributes on Popen objects don't exist anymore
on Unices (since CPython 3.4). As these buffers are not accessible
anymore in finish(), move the status check and possible exception
throwing to cleanup(), where they are still available.
Don't silently drop exceptions; this shows that ProcessStandin
previously used by HTMLWriter was also buggy (communicate() needed to
return bytes, not str); instead of using it, just do all the work in
finish(), similarly to PillowWriter).
61a0e41 to
02e5358
Compare
dopplershift
approved these changes
Oct 2, 2018
WeatherGod
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _std{out,err}_buff attributes on Popen objects don't exist anymore
on Unices (since CPython 3.4). As these buffers are not accessible
anymore in finish(), move the status check and possible exception
throwing to cleanup(), where they are still available.
Don't silently drop exceptions; this shows that ProcessStandin
previously used by HTMLWriter was also buggy (communicate() needed to
return bytes, not str); instead of using it, just do all the work in
finish(), similarly to PillowWriter).
Closes the first part of #9205 (but not #9205 (comment)).
PR Summary
PR Checklist