Skip to content

Move check for ImageMagick Windows path to bin_path(). #12371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2018
Merged

Move check for ImageMagick Windows path to bin_path(). #12371

merged 1 commit into from
Oct 3, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 2, 2018

That's a perfectly reasonable place to put the registry check and avoids
introducing an additional private helper method.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the imagemagick-binpath branch from b9fef3a to bb7a182 Compare October 2, 2018 15:56
@timhoffm
Copy link
Member

timhoffm commented Oct 3, 2018

Travis should be fixed by #12366. Would you mind to rebase? Even though it's a bit cumbersome, I'm feeling more comfortable just merging code with completely passing tests.

@anntzer
Move check for ImageMagick Windows path to bin_path().
59b546f 
That's a perfectly reasonable place to put the registry check and avoids
introducing an additional private helper method.
@anntzer
Copy link
Contributor Author

anntzer commented Oct 3, 2018

rebased

@anntzer anntzer force-pushed the imagemagick-binpath branch from bb7a182 to 59b546f Compare October 3, 2018 10:17
@timhoffm timhoffm merged commit 39c23a8 into matplotlib:master Oct 3, 2018
@anntzer anntzer deleted the imagemagick-binpath branch October 3, 2018 15:50
@QuLogic QuLogic added this to the v3.1 milestone Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

@dopplershift dopplershift

Labels
topic: animation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @timhoffm @dopplershift @QuLogic