Skip to content

Remove two examples. #12372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Remove two examples. #12372

merged 1 commit into from
Oct 2, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 2, 2018

arctest.py was (from the old changelog entries) intended as a test for
the long-obsoleted draw_arc method; it's not a particularly relevant
example otherwise (there are better examples for showcasing markers).
It's also right now at the very top of the examples list, which it
doesn't deserve.
https://matplotlib.org/gallery/lines_bars_and_markers/arctest.html#sphx-glr-gallery-lines-bars-and-markers-arctest-py

interp_demo.py is an example of using np.interp and not particularly
great at doing that, as one could get nearly the same plot (visually)
without doing interpolation but by using a dashed linestyle... If
anything it belongs to the numpy docs, not the matplotlib docs.
https://matplotlib.org/gallery/lines_bars_and_markers/interp_demo.html#sphx-glr-gallery-lines-bars-and-markers-interp-demo-py

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

arctest.py was (from the old changelog entries) intended as a test for
the long-obsoleted draw_arc method; it's not a particularly relevant
example otherwise (there are better examples for showcasing markers).
It's also right now at the very top of the examples list, which it
doesn't deserve.

interp_demo.py is an example of using np.interp and not particularly
great at doing that, as one could get nearly the same plot (visually)
without doing interpolation but by using a dashed linestyle...  If
anything it belongs to the numpy docs, not the matplotlib docs.
Copy link
Member

@ImportanceOfBeingErnest ImportanceOfBeingErnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'd usually be cautious to remove examples, the two cases here are indeed pretty useless.
Still, a second opinion on such removal would be good (hence not directly merging).

@jklymak jklymak merged commit 19701f5 into matplotlib:master Oct 2, 2018
@anntzer anntzer deleted the remove-examples branch October 2, 2018 20:01
@QuLogic QuLogic added this to the v3.1 milestone Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants