Don't crash on invalid registry font entries on Windows. #12408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Oct 5, 2018
jklymak
approved these changes
Oct 5, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 5, 2018
…tries on Windows.
Closed
jklymak
added a commit
that referenced
this pull request
Oct 5, 2018
…408-on-v3.0.x Backport PR #12408 on branch v3.0.x (Don't crash on invalid registry font entries on Windows.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #12406, see discussion there.
I didn't check whether this is a regression due to the simplification of the registry reader in 3.0, but it seems reasonable to target this to 3.0.x anyways.
PR Checklist