Move font cache rebuild out of exception handler #12416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Oct 5, 2018
jklymak
reviewed
Oct 5, 2018
lib/matplotlib/font_manager.py
Outdated
| except json.JSONDecodeError: | ||
| _log.warning("Font cache parsing failed %s", _fmcache) | ||
|
|
||
| if (not hasattr(fontManager, '_version') or |
There was a problem hiding this comment.
can't fontManager be None here? If so, won't fontManager._version != FontManager.__version__ give an AttributeError?
There was a problem hiding this comment.
>python -c "fontManager = None; print(not hasattr(fontManager, '_version') or fontManager._version != 123)"
True
However (version mismatch) log message is misleading in this situation
There was a problem hiding this comment.
Python is so unexpected sometimes...
I guess the log message is misleading, but you'll already have had one before with the real error, so prob fine? Or you could just check that fontManager is not None before the rest of the conditional...
There was a problem hiding this comment.
I have updated the PR, now we should be fine.
The purpose of the patch is to make tracebacks from cache rebuilding clearer.
72444e6 to
8d6196e
Compare
jklymak
approved these changes
Oct 5, 2018
|
Thanks @Kojoley ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the patch is to make tracebacks from cache rebuilding clearer.