Deprecate Axes3D.plot_surface(shade=None) #12430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a640c78 to
3bd268d
Compare
tacaswell
approved these changes
Oct 7, 2018
3bd268d to
526b856
Compare
WeatherGod
approved these changes
Oct 8, 2018
4 tasks
|
@timhoffm I'm not sure what the final meaning is supposed to be; can you implement the removal of this deprecation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Axes3D.plot_surface(shade=None)has the same semantics asshade=False. This is an unintended implementation detail and should not be allowed.Closes #11154.
PR Checklist