-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add a "density" kwarg to hist2d #11070 #12436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@anntzer Could you elaborate more? Thanks. |
What the above comment means is that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the signature must also be propagated to pyplot.py
. To do so, please run python tools/boilerplate.py
to update the auto-generated part of pyplot.py
and add the result to the commit.
lib/matplotlib/axes/_axes.py
Outdated
@@ -6865,7 +6876,16 @@ def hist2d(self, x, y, bins=10, range=None, normed=False, weights=None, | |||
in effect to gamma correction) can be accomplished with | |||
`.colors.PowerNorm`. | |||
""" | |||
if density is not None and normed is not None: | |||
raise ValueError("kwargs 'density' and 'normed' cannot be used " | |||
"simultaneously. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be re-wrapped to save a line.
@timhoffm Thanks. |
Unfortunately, our master branch has evolved since you branched your local copy. Therefore the pyplot code you could generate does not fit to the current master anymore. Please rebase your branch to the current upstream master (ask if you need advice how to do it). |
@timhoffm Thanks for the help. I did |
Seems you have removed any commits from this PR. Here is what the documentation tells about rebasing. |
@timhoffm @ImportanceOfBeingErnest Thank for the reference. I went too far before I saw your comment. :) Here is my new attempt. Thanks for the help. |
Fix #11070