Skip to content

Get rid of a signed-compare warning. #12441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2018
Merged

Get rid of a signed-compare warning. #12441

merged 1 commit into from
Oct 8, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 8, 2018

rect_i.x1 is signed but width is unsigned. Casting width to signed is
consistent with the rest of the code.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Get rid of a signed-compare warning.
9824813 
rect_i.x1 is signed but width is unsigned.  Casting width to signed is
consistent with the rest of the code.
@anntzer anntzer added this to the v3.1 milestone Oct 8, 2018
@jklymak jklymak merged commit 52fa0ee into matplotlib:master Oct 8, 2018
@anntzer anntzer deleted the signed-compare branch October 8, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm