Make FontManager.defaultFont a property, to avoid hardcoding the prefix. #12472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Oct 10, 2018
When serialized to json, FontManager stores paths that are relative to mpl-data (i.e. fonts shipped by Matplotlib) to relative paths; this ensures that the resulting fontList.json stays valid across multiple venvs (as the venv prefix does not end up in the json file). The same issue happens with defaultFont: currently, it includes the venv prefix. Instead of adding more layers to the json serialization/deserialization, just don't store it into fontList.json but compute defaultFont dynamically instead.
|
Done. |
timhoffm
approved these changes
Oct 11, 2018
jklymak
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serialized to json, FontManager stores paths that are relative to
mpl-data (i.e. fonts shipped by Matplotlib) to relative paths; this
ensures that the resulting fontList.json stays valid across multiple
venvs (as the venv prefix does not end up in the json file).
The same issue happens with defaultFont: currently, it includes
the venv prefix. Instead of adding more layers to the json
serialization/deserialization, just don't store it into fontList.json
but compute defaultFont dynamically instead.
PR Summary
PR Checklist