Skip to content

MAINT: numpy deprecates asscalar in 1.16 #12478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Oct 10, 2018

PR Summary

Small clean up to avoid deprecation warnings. See numpy/numpy#12123

PR Checklist

  • Has Pytest style unit tests (No change)
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related (No change)
  • Documentation is sphinx and numpydoc compliant (N/A)
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) (N/A)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way (N/A)

@dstansby dstansby added this to the v3.1 milestone Oct 10, 2018
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to back-port this at all?

@tacaswell tacaswell modified the milestones: v3.1, v3.0.x Oct 11, 2018
@tacaswell
Copy link
Member

Do we want to backport to 2.2.x as this will prevent an eventual bug?

@anntzer anntzer modified the milestones: v3.0.x, v2.2.4 Oct 12, 2018
@anntzer anntzer merged commit 2980184 into matplotlib:master Oct 12, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 12, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 12, 2018
@ksunden ksunden deleted the asscalar_dep branch October 12, 2018 21:29
QuLogic added a commit that referenced this pull request Oct 12, 2018
…478-on-v3.0.x

Backport PR #12478 on branch v3.0.x (MAINT: numpy deprecates asscalar in 1.16)
timokau added a commit to timokau/nixpkgs that referenced this pull request Feb 11, 2019
Numpy deprecated asscalar in 1.16. This will be fixed in the next
matplotlib version, but to avoid deprecation warnings (and because they
are breaking the sage testsuite), it can't hurt to backport the fix
already.

Upstream: matplotlib/matplotlib#12478
timokau added a commit to NixOS/nixpkgs that referenced this pull request Feb 11, 2019
* python.pkgs.matplotlib: add numpy 1.6 compat patch

Numpy deprecated asscalar in 1.16. This will be fixed in the next
matplotlib version, but to avoid deprecation warnings (and because they
are breaking the sage testsuite), it can't hurt to backport the fix
already.

Upstream: matplotlib/matplotlib#12478

* sage: add numpy 1.16 compatibility patch

https://trac.sagemath.org/ticket/27000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants