Skip to content

Test slider orientation #12482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2018
Merged

Test slider orientation #12482

merged 1 commit into from
Oct 11, 2018

Conversation

timhoffm
Copy link
Member

PR Summary

#10746 added vertical sliders. However, there was just a simple acceptance test.

This PR extends the test to actually verify the layout of the slider patch and thus actually test the orientation.

@timhoffm timhoffm added this to the v3.1 milestone Oct 10, 2018
@ImportanceOfBeingErnest ImportanceOfBeingErnest merged commit dab005d into matplotlib:master Oct 11, 2018
@timhoffm timhoffm deleted the test-slider-orientation branch October 11, 2018 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @QuLogic @ImportanceOfBeingErnest