DOC: clarify min supported version wording #12504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tacaswell
commented
Oct 12, 2018
- Has Pytest style unit tests
- Code is Flake 8 compliant
- New features are documented, with examples if plot related
- Documentation is sphinx and numpydoc compliant
- Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
- Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
anntzer
reviewed
Oct 12, 2018
doc/devel/min_dep_policy.rst
Outdated
| - support minor versions of ``Python`` initially released | ||
| 36 months prior to our planned release date. | ||
| - support minor versions of ``numpy`` initially released in the 36 | ||
| months prior to our planned release dat or oldest that supports the |
anntzer
reviewed
Oct 12, 2018
doc/devel/min_dep_policy.rst
Outdated
|
|
||
| with compiled extensions | ||
| minor versions released in the last 3 years | ||
| minor versions initially released in the 36 months prior to our release |
anntzer
reviewed
Oct 12, 2018
doc/devel/min_dep_policy.rst
Outdated
| or the oldest that support our minimum python + numpy | ||
|
|
||
| without complied extensions | ||
| minor versions released in the last 2 years or the oldest that | ||
| supports our minimum python. | ||
| minor versions initially released in the 24 months prior to our release |
d695c84 to
c816b09
Compare
|
force-pushed to fix typos / omissions. |
QuLogic
reviewed
Oct 12, 2018
| - support minor versions of ``numpy`` initially released in the | ||
| previous 3 years or oldest that supports the minimum python version | ||
| (which ever is higher) | ||
| - support minor versions of ``Python`` initially released |
There was a problem hiding this comment.
This should have 'in the' like the NumPy line, no? Right now it reads as if only Python older than 3 years is supported and nothing newer.
|
LGTM 👍 |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 13, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 13, 2018
QuLogic
added a commit
that referenced
this pull request
Oct 13, 2018
…504-on-v3.0.0-doc Backport PR #12504 on branch v3.0.0-doc (DOC: clarify min supported version wording)
timhoffm
pushed a commit
that referenced
this pull request
Oct 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.