Backport PR #12363 on branch v3.0.x #12512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Oct 12, 2018
| @@ -321,6 +321,8 @@ def __init__(self, ax, direction): | |||
| raise KeyError("direction must be one of left, right, bottom, top") | |||
|
|
|||
| def __call__(self, renderer): | |||
| vl = [self._get_func(ax.get_tightbbox(renderer, False), | |||
| ax.bbox) for ax in self._ax_list] | |||
| get_func = self._get_func_map[self._direction] | |||
There was a problem hiding this comment.
self._get_func still exists in this branch, so I think this change was not strictly necessary, but it's probably fine.
There was a problem hiding this comment.
Ha no you were right - I chose the wrong branch for that change ;-)
547c5ab to
65bedc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: errors in get_position changes
PR Summary
PR Checklist