Avoid quadratic behavior when accumulating stickies. #12546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When plotting 10000 lines, this gives a ~10% improvement in performance.
anntzer
commented
Oct 17, 2018
| @@ -2405,12 +2405,12 @@ def autoscale_view(self, tight=None, scalex=True, scaley=True): | |||
|
|
|||
| if self.use_sticky_edges and (self._xmargin or self._ymargin): | |||
| stickies = [artist.sticky_edges for artist in self.get_children()] | |||
| x_stickies = sum([sticky.x for sticky in stickies], []) | |||
| y_stickies = sum([sticky.y for sticky in stickies], []) | |||
| x_stickies = np.array([x for sticky in stickies for x in sticky.x]) | |||
There was a problem hiding this comment.
np.isclose is called just below anyways so converting to array here vs just below shouldn't affect performance.
dopplershift
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When plotting 10000 lines, this gives a ~10% improvement in performance.
xref #12542.
PR Summary
PR Checklist