Disable sticky edge accumulation if no autoscaling. #12547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there's no margin to be added, we don't need sticky edges, but if autoscaling is off, we _also_ don't need the sticky edges. This saves a lot of time when plotting many artists, like in matplotlib#12542.
|
I've never looked at this part of the code - what happens if the user turns autoscale on after the artists are added? |
|
Nothing different from before. This list is just used in the helper function below, which returns early in the cases just added to the condition. |
tacaswell
approved these changes
Oct 17, 2018
dopplershift
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
If there's no margin to be added, we don't need sticky edges, but if autoscaling is off, we also don't need the sticky edges. This saves a lot of time when plotting many artists, like in #12542.
Note this doesn't fix the problem in #12542, it just helps if you've already disabled autoscale as in #12542 (comment) in that you don't need to disable sticky edges yourself as well.
PR Checklist