Skip to content

BUG: mplot3d: Don't crash if azim or elev are non-integral #12573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2018

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Oct 20, 2018

Formatting these via a format string causes 'inf' or 'nan' to be displayed in the status bar, which is much better than crashing because the user tried to rotate.

Extracted from #8896 (comment), since that PR is a can of worms, but this small fix is not.

No unit tests, because testing mouse interaction sounds super hard.

Formatting these via a format string causes 'inf' or 'nan' to be displayed in the status bar, which is much better than crashing because the user tried to rotate.
@eric-wieser
Copy link
Contributor Author

This also changes the rendering of -0, but that probably doesn't matter.

@WeatherGod WeatherGod merged commit e231439 into matplotlib:master Oct 20, 2018
@WeatherGod
Copy link
Member

@meeseeksdev backport to v3.0.x

@WeatherGod
Copy link
Member

WeatherGod commented Oct 20, 2018

@meeseeksdev backport to v2.2.x

timhoffm pushed a commit that referenced this pull request Oct 20, 2018
@QuLogic QuLogic added this to the v2.2.4 milestone Oct 20, 2018
@eric-wieser eric-wieser deleted the fractional-view-angle branch March 23, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants