add explanations and examples to the docstring of violinplot #12585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the difference between passing an array and passing a sequences of vectors.
story645
requested changes
Oct 22, 2018
|
Hi @wywang-nyu, this PR is very welcome and thank you for making it. Do you plan on making the requested changes? |
andreawwenyi
commented
Nov 14, 2018
Hi, sorry for the delay! I totally forgot about this. I just made the request changes, please review! Thank you. |
story645
reviewed
Nov 15, 2018
| dataset : Array or a sequence of vectors. | ||
| The input data. | ||
| dataset : 2D Array/Matrix or a sequence of vectors. | ||
| The input data. |
There was a problem hiding this comment.
don't need "the input data". Notes about data haven't been moved to notes section"
timhoffm
requested changes
Nov 17, 2018
There was a problem hiding this comment.
flake8 complains (see also the flake8 Travis CI build):
./lib/matplotlib/axes/_axes.py:7874:80: E501 line too long (133 > 79 characters)
./lib/matplotlib/axes/_axes.py:7880:26: W291 trailing whitespace
./lib/matplotlib/axes/_axes.py:7881:80: E501 line too long (116 > 79 characters)
./lib/matplotlib/axes/_axes.py:7882:80: E501 line too long (108 > 79 characters)
3 E501 line too long (133 > 79 characters)
1 W291 trailing whitespace
Please fix to comply with our coding conventions.
|
closing because this got kind of addressed in #14107 but will totally reopen if @andrea-w-wang has the bandwidth to readdress this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explanations and examples to the docstring of violinplot to explain how violinplot handles differently w.r.t. sequence of vectors and 2D array.
Closes #12178
PR Summary
PR Checklist