Allow unit input to FancyArrowPatch #12643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Oct 26, 2018
| @@ -4253,8 +4261,10 @@ def get_path_in_displaycoord(self): | |||
| dpi_cor = self.get_dpi_cor() | |||
|
|
|||
| if self._posA_posB is not None: | |||
There was a problem hiding this comment.
This seems good - is it worth looking at the other patches to see if we need to add this? You could test with the same test as below and see if they fail?
There was a problem hiding this comment.
I don't have the bandwidth to do this at the moment; perhaps quite a nice thing to add as a new-contributor friendly issue though.
jklymak
approved these changes
Nov 5, 2018
dopplershift
approved these changes
Nov 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12591. I added
_convert_xy_unitsto thePatchbase class, as I figure it's probably useful for otherPatchsubclasses too.