Skip to content

Don't warn when accessing deprecated properties from the class. #12653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Don't warn when accessing deprecated properties from the class. #12653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions lib/matplotlib/cbook/deprecation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,18 +201,21 @@ def finalize(wrapper, new_doc):

class _deprecated_property(property):
def __get__(self, instance, owner):
from . import _warn_external
_warn_external(message, category)
if instance is not None:
from . import _warn_external
_warn_external(message, category)
return super().__get__(instance, owner)

def __set__(self, instance, value):
from . import _warn_external
_warn_external(message, category)
if instance is not None:
from . import _warn_external
_warn_external(message, category)
return super().__set__(instance, value)

def __delete__(self, instance):
from . import _warn_external
_warn_external(message, category)
if instance is not None:
from . import _warn_external
_warn_external(message, category)
return super().__delete__(instance)

def finalize(_, new_doc):
Expand Down