Skip to content

Remove deprecation warnings in tests #12686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Conversation

dstansby
Copy link
Member

Removes

lib/matplotlib/axes/_axes.py:4190
  /home/travis/build/matplotlib/matplotlib/lib/matplotlib/axes/_axes.py:4190:
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

@dstansby dstansby added this to the v3.1 milestone Oct 31, 2018
@tacaswell tacaswell modified the milestones: v3.1, v3.0.x, v2.2.4 Oct 31, 2018
@tacaswell
Copy link
Member

Might as well backport this all the way back as this will turn into a "will not import error" on the 2.2 branch within our support window (3.8 is scheduled for 2019-10)

@timhoffm timhoffm merged commit 8a7666d into matplotlib:master Oct 31, 2018
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 31, 2018

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v2.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 8a7666d3dca59d477cc98fda2f7889782d353bb7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #12686: Remove deprecation warnings in tests'
  1. Push to a named branch :
git push YOURFORK v2.2.x:auto-backport-of-pr-12686-on-v2.2.x
  1. Create a PR against branch v2.2.x, I would have named this PR:

"Backport PR #12686 on branch v2.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 31, 2018
QuLogic added a commit that referenced this pull request Nov 1, 2018
…686-on-v3.0.x

Backport PR #12686 on branch v3.0.x (Remove deprecation warnings in tests)
@dstansby dstansby deleted the test-deprec branch November 1, 2018 09:16
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Nov 1, 2018
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Nov 1, 2018
thoo added a commit to thoo/matplotlib that referenced this pull request Nov 3, 2018
* 'master' of https://github.com/matplotlib/matplotlib: (50 commits)
  Set up CI with Azure Pipelines (matplotlib#12617)
  Added comment for test.
  Correctly remove nans when drawing paths with pycairo.
  Improve docs on Axes limits and direction
  Extend sphinx Makefile to cleanup completely
  Remove explicit figure number
  Update contributing.rst
  Update contributing.rst
  DOC: Add badge and link to making PR tutorial
  Added test cases for scatter plot: 1) empty data/color, 2) pandas.Series with non-0 starting index.
  TST: mark test_constrainedlayout.py::test_colorbar_location as flaky (matplotlib#12683)
  Remove deprecation warnings in tests (matplotlib#12686)
  Make ticks in demo_axes_rgb.py visible
  Change ipython block to code-block
  Improve linestyles example (matplotlib#12586)
  document-textpath
  Fix index out of bound error for testing first element of iterable.
  TST: test that get_ticks works
  FIX: fix error in colorbar.get_ticks not having valid data
  Replaced warnings.warn with either logging.warnings or cbook._warn_external
  ...
@timhoffm timhoffm mentioned this pull request Nov 3, 2018
@QuLogic QuLogic modified the milestones: v2.2.4, v3.0.2 Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants