Skip to content

DOC: Link to "How to make a PR" tutorials as badge and in contributing #12691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2018

Conversation

story645
Copy link
Member

@story645 story645 commented Nov 1, 2018

Going by a conversation with @erinleeryan, it was suggested that a How to make a PR tutorial might be useful for new contributors. The unidata/siphon repository addresses this by having a badge that links out to https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github. @phobson raised the concern about the tutorial not being open source, so the alternative links are

My concern with the lab is that it's very oriented towards github pages & requires all sorts of permissions to turn on, but on the flip side it's probably the clearer tutorial.

The badge is PR Welcome and was made using https://shields.io/#/

The badge is [![PR Welcome](https://img.shields.io/badge/PR-Welcome-%23FF8300.svg?)][https://git-scm.com/book/en/v2/GitHub-Contributing-to-a-Project]

Going by a conversation with @erinleeryan, it was suggested that a How to make a PR tutorial might be useful for new contributors. The [unidata/siphon](https://github.com/Unidata/siphon) repository addresses this by having a badge that links out to https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github. @phobson raised the concern about the tutorial not being open source, so the alternative links are 
* https://git-scm.com/book/en/v2/GitHub-Contributing-to-a-Project 
* https://lab.github.com/githubtraining/introduction-to-github

My concern with the lab is that it's very oriented towards github pages & requires all sorts of permissions to turn on, but on the flip side it's probably the clearer tutorial.
@story645 story645 changed the title Links to "How to make a PR" tutorials as badge and in contributing DOC: Link to "How to make a PR" tutorials as badge and in contributing Nov 1, 2018
Copy link
Member

@phobson phobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dstansby dstansby added this to the v3.1 milestone Nov 1, 2018
@dstansby dstansby merged commit cb0135c into matplotlib:master Nov 1, 2018
@story645 story645 deleted the pr-badge branch November 1, 2018 16:08
@ImportanceOfBeingErnest
Copy link
Member

Would it make sense to backport this to the v3.0.0-doc branch, to appear already on the website the next time the docs are built?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants