Skip to content

Use the builtin GTK3 FileChooser rather than our custom subclass. #12748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

Use the builtin GTK3 FileChooser rather than our custom subclass. #12748

merged 1 commit into from
Feb 27, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 5, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Nov 5, 2018
QuLogic
QuLogic reviewed Nov 6, 2018
View reviewed changes
lib/matplotlib/backends/backend_gtk3.py
dialog.set_current_name(
str(Path(dialog.get_current_name()).with_suffix("." + fmt)))

dialog.set_current_folder(rcParams["savefig.directory"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current recommendations are to not even call this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but that'd mean not respecting the documented rcParam...

@QuLogic
Copy link
Member

QuLogic commented Nov 16, 2018

Seems you have flake8 issues.

@anntzer
Copy link
Contributor Author

anntzer commented Nov 17, 2018

should be fixed now

jklymak
jklymak approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging on @QuLogic review. Assuming @anntzer tested and that it works, because I don't have GTK3 installed...

@jklymak jklymak merged commit d4b6a7e into matplotlib:master Feb 27, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 27, 2019
@jklymak
Backport PR matplotlib#12748: Use the builtin GTK3 FileChooser rather…
18a7ca2 
… than our custom subclass.
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 27, 2019
Merged
@anntzer anntzer deleted the gtkfilechooser branch February 28, 2019 01:01
QuLogic added a commit that referenced this pull request Feb 28, 2019
@QuLogic
Merge pull request #13538 from meeseeksmachine/auto-backport-of-pr-12…
13958b7 
…748-on-v3.1.x

Backport PR #12748 on branch v3.1.x (Use the builtin GTK3 FileChooser rather than our custom subclass.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
GUI: gtk
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @jklymak