Fix overwriting suptitle #1276
Fix overwriting suptitle #1276
Conversation
|
Do we want a test for this? If not, this is good to go. |
|
Do we want the kwargs to be ignored on subsequent calls, as they will be in the present state of this PR? |
|
Eyes like a hawk. I will fix that. Thanks. |
|
I think that's better. |
|
Since this is a bugfix, I opened a new pull request that targets |
Ah the old gray line.... 😄 - one could equally argue that you are extending previously designed behaviour and therefore this is an enhancement 😉. Either way, as I've made clear before, I really hope it makes no difference and we can get on and get a v1.3 release (which IMHO is already feature packed) out. |
|
That's a fair point. In my opinion, the design before this change appears to overlook the issue of it not being overwritten on an update. In any case, mention of its behaviour in the docstring, at a minimum, should go into v1.2.1. Though, as you've said, it probably makes no difference. |
Fixes #1262.
Note, once the position is set, it can't be changed on a new call to
suptitle. I think it might be a better idea to allow the user to change the position on subsequent calls tosuptitle.