Do not rely on external stack frame to exist #12771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using matplotlib in an embedded Python interpreter (such as in Julia package PyCall.jl), stack frame may not exist outside matplotlib. Therefore, it is better to not assume `frame.f_back` to be an existing call frame. See: JuliaPy/PyPlot.jl#409
WeatherGod
approved these changes
Nov 8, 2018
anntzer
reviewed
Nov 8, 2018
| @@ -1990,6 +1990,8 @@ def _warn_external(message, category=None): | |||
| """ | |||
| frame = sys._getframe() | |||
| for stacklevel in itertools.count(1): # lgtm[py/unused-loop-variable] | |||
| if frame is None: | |||
There was a problem hiding this comment.
Would suggest leaving a comment (as just below) so that people realize when this can happen.
There was a problem hiding this comment.
I took the liberty of adding such a comment
|
thanks all! |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
Thanks for the prompt review and merge! |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Nov 8, 2018
…exist
Conflicts:
lib/matplotlib/cbook/__init__.py
- also backported lgtm noqa flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When using matplotlib in an embedded Python interpreter (such as in Julia package PyCall.jl), stack frame may not exist outside matplotlib. Therefore, it is better to not assume
frame.f_backto be an existing call frame.See: JuliaPy/PyPlot.jl#409
PR Checklist