Remove ticks and titles from tight bbox tests. #12790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These text elements may shift with different versions of FreeType, making the tight bbox results unstable when building against external newer versions.
jklymak
reviewed
Nov 10, 2018
dstansby
approved these changes
Nov 11, 2018
timhoffm
approved these changes
Nov 11, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 11, 2018
|
Um, ok I guess I should have blocked. Why was this change helpful? |
|
For exactly the reason stated in the summary? |
QuLogic
added a commit
that referenced
this pull request
Nov 11, 2018
…790-on-v3.0.x Backport PR #12790 on branch v3.0.x (Remove ticks and titles from tight bbox tests.)
|
But how were any other tests passing? The reason I ask is that the tightbbox machinery is supposed to care about text. So removing text, while not a big deal in this case, seems a strange thing to do. |
|
I maintain a set of images generated with 2.9.1 for those tests. That's why I asked about constrained layout issues on gitter from time to time. |
|
Ok thanks. I’ll keep that in mind for future tests. Obviously it’s nice not to have to make image tests for everything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
These text elements may shift with different versions of FreeType, making the tight bbox results unstable when building against external newer versions (such as this Fedora build against FreeType 2.9.1.)
PR Checklist