Skip to content

Fix TypeError when calculating tick_values #12809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timhoffm
Copy link
Member

PR Summary

Fixes #12806.

This was caused by a misplaced parentheses. Introduced in 54d6f08 (attn. @efiring).

@timhoffm timhoffm added this to the v2.2.4 milestone Nov 14, 2018
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How embarrassing! Not only did I get it wrong the first time, but when I went back to look at it just now, I didn't see it until I looked at your patch. Thank you for catching and fixing it.

@ImportanceOfBeingErnest ImportanceOfBeingErnest merged commit 6a61f93 into matplotlib:master Nov 15, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 15, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 15, 2018
@timhoffm timhoffm deleted the fix-ticker-type-error branch November 15, 2018 07:21
QuLogic added a commit that referenced this pull request Jan 22, 2019
…809-on-v3.0.x

Backport PR #12809 on branch v3.0.x (Fix TypeError when calculating tick_values)
QuLogic added a commit that referenced this pull request Jan 22, 2019
…809-on-v2.2.x

Backport PR #12809 on branch v2.2.x (Fix TypeError when calculating tick_values)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants