Skip to content

BUG: subs in LogLocator is not always an one dimensional array #12814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jor-
Copy link
Contributor

@jor- jor- commented Nov 15, 2018

Fixes #12806.

@ImportanceOfBeingErnest
Copy link
Member

I think I would like to see a usecase where subs is an array of zero dimension. As I see it this can only happen if you plug in a single number in the instantiation, which is not allowed according to the documentation.

@jor-
Copy link
Contributor Author

jor- commented Nov 15, 2018

Thank you for pointing me to the documentation. I used a single number in the instantiation and thought this was allowed.

@jor- jor- closed this Nov 15, 2018
@ImportanceOfBeingErnest
Copy link
Member

I see. Of course you are free to then change the documentation as well, if you feel like single numbers should be allowed for. Or, if you think that other users may fall for this as well, to provide a better error message in that case.

@jor-
Copy link
Contributor Author

jor- commented Nov 21, 2018

I made PR #12860 which adds some more explanatory error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants