Skip to content

Bump oldest supported numpy to 1.11. #12858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2018
Merged

Bump oldest supported numpy to 1.11. #12858

merged 1 commit into from
Nov 24, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 21, 2018

PR Summary

Per discussion in #12358.
(The divmod fix is now unnecessary since numpy/numpy@34c2369 went in in numpy 1.11.)

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Nov 21, 2018
@QuLogic
Copy link
Member

QuLogic commented Nov 24, 2018

According to coverage changes, you've missed this bit.

@anntzer
Copy link
Contributor Author

anntzer commented Nov 24, 2018

Thanks for the notice, removed that test too.

@timhoffm timhoffm merged commit 2698288 into matplotlib:master Nov 24, 2018
@anntzer anntzer deleted the numpy111 branch November 24, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @jklymak @timhoffm