ENH: LogLocator: check for correct dimension of subs added #12860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02f00fd to
517b575
Compare
timhoffm
reviewed
Nov 21, 2018
timhoffm
approved these changes
Nov 24, 2018
|
This needs tests of the possible errors. Not quite clear on the use case here. Argument checking is fine, but this is relatively obscure API and it seems we can trust that the user has read the doc string. I assume if these strictures aren’t followed an error pops up a little further down the line. Is that error too mysterious that we need these checks? |
|
@jor- I took the liberty of rebasing this on current master, adding a test, and force-pushing. I hope you do not mind. |
7fa7dd9 to
06507f2
Compare
anntzer
approved these changes
Aug 25, 2019
|
@tacaswell : Thanks for finishing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some checks with explanatory error messages are added to the
subsmethod of theLogLocator.