Simplify use of Path._fast_from_codes_and_verts. #12868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16b0798 to
352d933
Compare
All uses of Path._fast_from_codes_and_verts create the internals dict by copying the attribute from another Path. Instead of having the caller create that dict, just let him pass a Path from which to copy the attributes. Note that this means that the copying will now also use the simplify_threshold from the previous Path; however I think it is clear that the previous behavior of not copying it was an oversight (compounded by the fact that simplify_threshold is rarely, if ever, overwritten on a per-Path basis).
jklymak
approved these changes
Nov 30, 2018
timhoffm
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
All uses of Path._fast_from_codes_and_verts create the internals dict by
copying the attribute from another Path. Instead of having the caller
create that dict, just let him pass a Path from which to copy the
attributes.
Note that this means that the copying will now also use the
simplify_threshold from the previous Path; however I think it is clear
that the previous behavior of not copying it was an oversight
(compounded by the fact that simplify_threshold is rarely, if ever,
overwritten on a per-Path basis).
Builds on top of #12846, which removes one of these attributes (has_nonfinite, now a deprecated property).
Preparatory work towards #12850.
PR Checklist