fooImage -> foo_image in testing/compare.py #12877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Nov 24, 2018
lib/matplotlib/testing/compare.py
Outdated
| "Image sizes do not match expected size: {} " | ||
| "actual size {}".format(expectedImage.shape, actualImage.shape)) | ||
| if expected_image.shape != actual_image.shape: | ||
| raise _imageComparisonFailure( |
There was a problem hiding this comment.
Suggested change
| raise _imageComparisonFailure( | |
| raise ImageComparisonFailure( |
lib/matplotlib/testing/compare.py
Outdated
| "actual size {}".format(expectedImage.shape, actualImage.shape)) | ||
| if expected_image.shape != actual_image.shape: | ||
| raise _imageComparisonFailure( | ||
| "_image sizes do not match expected size: {} " |
There was a problem hiding this comment.
Suggested change
| "_image sizes do not match expected size: {} " | |
| "Image sizes do not match expected size: {} " |
lib/matplotlib/testing/compare.py
Outdated
| expected_image = np.array(expected_image).astype(float) | ||
| actual_image = np.array(actual_image).astype(float) | ||
| if expected_image.shape != actual_image.shape: | ||
| raise _imageComparisonFailure( |
There was a problem hiding this comment.
Suggested change
| raise _imageComparisonFailure( | |
| raise ImageComparisonFailure( |
lib/matplotlib/testing/compare.py
Outdated
| actual_image = np.array(actual_image).astype(float) | ||
| if expected_image.shape != actual_image.shape: | ||
| raise _imageComparisonFailure( | ||
| "_image sizes do not match expected size: {} " |
There was a problem hiding this comment.
Suggested change
| "_image sizes do not match expected size: {} " | |
| "Image sizes do not match expected size: {} " |
Just to not make me cringe every time I read that file. Also deprecate the unused decorators.switch_backend decorator (now replaced by the backend pytest mark).
|
fixed, thanks, I guess that's what you get when doing a search replace :p |
timhoffm
approved these changes
Nov 24, 2018
jklymak
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to not make me cringe every time I read that file.
Also deprecate the unused decorators.switch_backend decorator (now
replaced by the backend pytest mark).
PR Summary
PR Checklist