Skip to content

Pin pytest to <3.8 (for 2.2.x) #12879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

Pin pytest to <3.8 (for 2.2.x) #12879

merged 1 commit into from
Dec 17, 2018

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Nov 24, 2018 •
edited
Loading

PR Summary

Fixes #12825 for 2.2.x (CI failure due to pytest warnings).

3.0.x is handled separately in #12878.

This limits

  • pytest<3.8 because 3.8 starts issueing warnings that we do not want to fix in the 2.2.x code.
  • pytest-rerunfailures<5 for the py27 build because that build uses pytest==3.1 and the new pytest-rerunfailures==5 requires pytest>=3.6.

@timhoffm timhoffm added this to the v2.2.4 milestone Nov 24, 2018
@timhoffm timhoffm force-pushed the fix-pytest-error-in-ci-2.2.x branch from cd27324 to d7e3789 Compare November 25, 2018 22:35
jklymak
jklymak approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I think the macosx failure was unrelated, but OTOH there are some changes to pytet-rerunfailures that I don't fully understand; why are those there?

@timhoffm
Copy link
Member Author

timhoffm commented Nov 26, 2018 •
edited
Loading

The changes to pytest-rerunfailures is neccesary because the recently released pytest-rerunfailures 5.0 requires pytest>=3.6. With pytest-rerunfailures<5 we're pinning to the latest version, that is compatible with pytest==3.1.

@jklymak
Copy link
Member

jklymak commented Nov 26, 2018

Hmm, but the OSX tests aren't passing. Looks lie something w/ homebrew though, and not this PR?

@timhoffm
Copy link
Member Author

timhoffm commented Nov 27, 2018 •
edited
Loading

Yes. I‘m not an OSX expert, but I‘m quite sure the failure is unrelated to the PR.

@tacaswell tacaswell merged commit 8482916 into matplotlib:v2.2.x Dec 17, 2018
@timhoffm timhoffm deleted the fix-pytest-error-in-ci-2.2.x branch December 17, 2018 19:58
@timhoffm timhoffm mentioned this pull request Dec 28, 2018
Closed
@ArchangeGabriel ArchangeGabriel mentioned this pull request Jan 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @jklymak @tacaswell