Write error messages to logger instead of stderr #12882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Nov 24, 2018
| @@ -1527,8 +1527,7 @@ def writeXref(self): | |||
| borken = False | |||
| for offset, generation, name in self.xrefTable: | |||
| if offset is None: | |||
| print('No offset for object %d (%s)' % (i, name), | |||
| file=sys.stderr) | |||
| _log.error('No offset for object %d (%s)', i, name) | |||
There was a problem hiding this comment.
Just lift the AssertionError that gets raised a few lines below to this point, instead.
e5f700e to
25e4eae
Compare
anntzer
approved these changes
Nov 26, 2018
jklymak
reviewed
Nov 26, 2018
|
This is a rather specific error message. I don't think someone will parse stderr for it. So, I'm fine without an API note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary