Deprecate public access to the vendored formlayout module. #12889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Changes such as #12885 are actually backcompat-breaking (in a strict sense) because calls of the form
FormLayout(data, comment, parent)
have changed their meaning (after that PR, the third argument is interpreted as thewith_margin
arg).In practice, there's no reason for
formlayout
to be public (the official version is PyPI-installable), so let's make it private.PR Checklist