Skip to content

Deprecate public access to the vendored formlayout module. #12889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 26, 2018

PR Summary

Changes such as #12885 are actually backcompat-breaking (in a strict sense) because calls of the form FormLayout(data, comment, parent) have changed their meaning (after that PR, the third argument is interpreted as the with_margin arg).

In practice, there's no reason for formlayout to be public (the official version is PyPI-installable), so let's make it private.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Nov 26, 2018
@anntzer anntzer force-pushed the private-vendor-formlayout branch from 013f9b6 to f859064 Compare November 26, 2018 10:12
@timhoffm timhoffm merged commit d5f4386 into matplotlib:master Nov 26, 2018
@anntzer anntzer deleted the private-vendor-formlayout branch November 26, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants