Backport PR #12848 on branch v3.0.2-doc (Fix spelling of the name Randall Munroe) #12895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically, this cannot go back to a doc branch beacause it changes py files. The CI failures come from #12878, which should be backported to the doc branch anyway. |
|
Ah yes, I did miss that. But it's not that it cannot go back, just that it will have no effect. However the change is in comments, so it doesn't really matter. |
|
I have no strong opinion on this. However in the past, also backporting pure docstring changes was discarded. |
|
I'll close this just for simplicity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #12848: Fix spelling of the name Randall Munroe