-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Debundle pyparsing #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debundle pyparsing #1290
Conversation
Yes, the pyparsing API seems to have stabilized since that message was written, and we currently ship "vanilla" pyparsing 1.5.5. However:
|
Fair enough, I'll work on less intrusive solution. Perhaps, checking for system pyparsing and fallback to bundled one if former is not found? |
Yes -- that's what we do with dateutil and pytz at the moment. |
Oh geez, I've made a mess... I wasn't aware that all my random commits will be subject to validation via Travis. Sorry for wasting your cycles. |
Don't worry about wasting our cycles -- you're saving a lot of our human cycles by working on this! You may also be interested in MEP11 -- which began in part as a result of this PR -- and the associated discussion on the mailing list. |
@mdboom & @Xarthisius - where does this sit with the new setup machinery? Is this now obsolete? |
@pelson: Thanks for pointing this out again. Yes, as of 1.3.0, pyparsing is unbundled and will be installed by |
Hi,
I'd like to revisit the issue of bundling pyparsing [1],[2]. Recently I've encounter python project that did import matplotlib.pyparsing so it's getting slightly out of hand. My question: do original point of "pyparsing API being too fluid" still stands, were your patches merged? Upstream repository seems to be quiet at the moment. Also I've been using maplotlib with pyparsing-1.5.6 without any problems
Cheers,
Kacper
[1] http://www.mail-archive.com/matplotlib-devel@lists.sourceforge.net/msg05108.html
[2] https://bugs.gentoo.org/show_bug.cgi?id=260025