Allow all valid hist.bins strings to be set in the rcparams #12908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Nov 30, 2018
timhoffm
approved these changes
Dec 1, 2018
|
Thanks for the PR and congratulations on your first contribution to matplotlib! Hoping to see you back some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently the one string that can be set in the rcParams is "auto". However there are a number of other strings that can be passed to the
binsargument ofhist. I think those should also be allowed to be set in the rcParams.Also note in the docs one of the allowed strings
'sturges'was repeated. I've removed the repeat.Apologies if I have made any process mistakes - this is my first PR to matplotlib. I also didn't get tests running locally but if they fail here I will do that and fix any issues.
PR Checklist