Deprecate public use of Formatter.pprint_val. #12924
Conversation
lib/matplotlib/ticker.py
Outdated
| return self._pprint_val(*args, **kwargs) | ||
|
|
||
| def _pprint_val(self, *args, **kwargs): | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Should get a comment, what this is supposd to do and how subclasses should implement it. This info is targeted at other developers.
There was a problem hiding this comment.
Moved the deprecation to each individual class, so no need for the NotImplemented base class version anymore.
It's really a helper method.
|
Thanks @anntzer . This is one we should be willing to roll back if we get complaints. |
|
@tacaswell Just to clarify why I deprecated these (it's not just "oh let's make them private because we can"): Right now it's quite difficult to follow the code flow in ticker code, and these pprint_val methods do not help at all as they can be inherited (so it's not even immediately clear which one you're getting) and don't have consistent semantics either. So the plan is to inline the relevant parts of the code into the callers as much as possible, to avoid having to trace back which pprint_val is being used where. |
It's really a helper method.
PR Summary
PR Checklist