Skip to content

Shorten an argument check. #12930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2018
Merged

Shorten an argument check. #12930

merged 1 commit into from
Dec 5, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 4, 2018

PR Summary

Minor nit noticed while reviewing #12880.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Dec 4, 2018
@story645
Copy link
Member

story645 commented Dec 5, 2018 •
edited
Loading

Can this be merged since the only failure is code cov?
Also does matplotlib support new style format strings?

@dopplershift
Copy link
Contributor

Up to you as a second dev. 😁 But I don't see a problem with it--it's not adding any new paths.

@story645 story645 merged commit 137effc into matplotlib:master Dec 5, 2018
@anntzer anntzer deleted the table branch December 5, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @story645 @dopplershift